search

fatclarence / pe

0 stars 0 forks source link

Annote-delete command does not throw error #4

Open fatclarence opened 4 years ago

fatclarence commented 4 years ago

Summary: typing "annotate-delete 1 p/all" should allow me to delete my first annotation. But if I have yet to make any annotations it should have thrown an error. But the error was only caught internally.

Steps to reproduce:

  1. type "annotate-delete 1 p/all"

Expected results: Offline copy of the first bookmark is clear of any annotations.

Actual results: Nothing.

Screenshot of issue: Screenshot 2019-11-15 at 5.14.06 PM.png

nus-pe-bot commented 4 years ago

Team's Response

Thanks for reporting this! Due to the difference in implementation, the existence of a cache for annotate-delete INDEX p/all is not checked although the other annotate-delete commands did, giving rise to what is observed.

However, given that users know they can only delete annotations when a bookmark has a cache and would rarely delete the entire annotations (unless they did a lot of annotations wrongly), I believe this will only cause occasional inconvenience to users but they can continue to use the product, given that no "offline cache is available!" is shown. Hence, we have decided to decrease the severity to medium instead.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Medium]. Originally [severity.High].

Reason for disagreement: [replace this with your reason]