search

fatedier / frp

A fast reverse proxy to help you expose a local server behind a NAT or firewall to the internet.
Apache License 2.0
80.97k stars 12.78k forks source link

Allow to store Basic Auth passwords hashed in config files #2448

Closed ravenclaw900 closed 2 years ago

ravenclaw900 commented 2 years ago

Allows to store passwords used for HTTP Basic Authentication (and dashboard and admin UI) hashed using BCrypt.

github-actions[bot] commented 2 years ago

Issues go stale after 30d of inactivity. Stale issues rot after an additional 7d of inactivity and eventually close.

ravenclaw900 commented 2 years ago

bump

github-actions[bot] commented 2 years ago

Issues go stale after 30d of inactivity. Stale issues rot after an additional 7d of inactivity and eventually close.

ravenclaw900 commented 2 years ago

bump

github-actions[bot] commented 2 years ago

Issues go stale after 30d of inactivity. Stale issues rot after an additional 7d of inactivity and eventually close.

ravenclaw900 commented 2 years ago

bump

github-actions[bot] commented 2 years ago

Issues go stale after 30d of inactivity. Stale issues rot after an additional 7d of inactivity and eventually close.

ravenclaw900 commented 2 years ago

bump

github-actions[bot] commented 2 years ago

Issues go stale after 30d of inactivity. Stale issues rot after an additional 7d of inactivity and eventually close.

ravenclaw900 commented 2 years ago

bump

github-actions[bot] commented 2 years ago

Issues go stale after 30d of inactivity. Stale issues rot after an additional 7d of inactivity and eventually close.

ravenclaw900 commented 2 years ago

bump

fatedier commented 2 years ago

Can you open an issue to describe more about your feature?

github-actions[bot] commented 2 years ago

Issues go stale after 30d of inactivity. Stale issues rot after an additional 7d of inactivity and eventually close.

ravenclaw900 commented 2 years ago

bump

github-actions[bot] commented 2 years ago

Issues go stale after 30d of inactivity. Stale issues rot after an additional 7d of inactivity and eventually close.

ravenclaw900 commented 2 years ago

Bump

github-actions[bot] commented 2 years ago

PRs go stale after 30d of inactivity. Stale PRs rot after an additional 7d of inactivity and eventually close.

ravenclaw900 commented 2 years ago

bump

ravenclaw900 commented 2 years ago

Sorry for the long wait, and all of the bump messages. Should work with the dashboard, admin UI, and http type proxies now. Quite a few functions, like HTTPBasicAuth and HTTPAuthWraper.ServeHTTP don't seem to do much, so I didn't add authentication there. Also, not sure if the RouteConfig is the best place to store the Hashed variable, but I didn't see anything else.

fatedier commented 2 years ago

You don't follow my solution in this comment https://github.com/fatedier/frp/issues/2747#issuecomment-1008950564 .

We need to consider the generality of the feature, instead of constantly adding new parameters.

By the way, we are planning to work on frp v2. I prefer not to keep maintaining these features in the current version.

ravenclaw900 commented 2 years ago

In that case, I'd be happy to close it and maybe try reimplementing in v2 later, with both hashing algorithms.