search

fatedier / frp

A fast reverse proxy to help you expose a local server behind a NAT or firewall to the internet.
Apache License 2.0
80.5k stars 12.74k forks source link

initialize tls config with TLS 1.2 #4191

Closed yuyoyuppe closed 2 weeks ago

yuyoyuppe commented 2 weeks ago

WHY

Fix frpc issue that prevents obtaining A-grade SSL rating from ssl labs caused by incorrect crypto/tls initialization that supports disabled TLS versions.

fatedier commented 2 weeks ago

This is the default behavior of Go 1.22, no modifications are needed.

yuyoyuppe commented 2 weeks ago

frpc v0.57.0 on Windows still has this issue. Is this just a pipeline thing then that would be fixed in the next release?

fatedier commented 2 weeks ago

I suggest you to write a simple Go application in your own environment and use the Go 1.22 compiler to further investigate possible reasons for the issue.

We are currently not inclined to make any changes in this area, but instead use the official default values, which are usually the result of various factors considered by the go community, such as perhaps taking into account widespread compatibility issues.

The ability for more advanced configurations is planned for v2, but will not be supported in the short term.

yuyoyuppe commented 2 weeks ago

You're right, I've just done a further testing and the problem is indeed fixed by just compiling frpc from the dev branch with the latest Go compiler.

So it's just a pipeline issue indeed.

Closing, thanks!