search

fateh999 / react-native-paper-dropdown

Dropdown using react native paper TextInput and Menu
121 stars 72 forks source link

Add key-value pair type to list type to pass custom data #71

Closed bombillazo closed 1 year ago

bombillazo commented 2 years ago

Hey @fateh999 , I'd like to contribute to this repo

fateh999 commented 2 years ago

Hi @bombillazo , Thanks for your pull request but i think this should be optional type. I am however working on a rewrite on this module so will try to incorporate this change soon.

bombillazo commented 2 years ago

That's great to hear!

I agree it should be optional. Indexes of the form [key: string] can be considered as being always optional so that would cover it. It'll be nice to have while we wait on the updated version.

Glad to help any way I can.

fateh999 commented 1 year ago

Hi, would you like to work on the rewrite of the library currently it is suffering from lot of issues, due to no maintenance. I would like to connect with you on Discord [ fateh999#5219 ] or Skype [ live:fateh.farooqui9 ]

On Thu, Jun 30, 2022 at 12:30 AM Hector Ayala @.***> wrote:

That's great to hear!

I agree it should be optional. Indexes of the form [key: string] can be considered as being always optional so that would cover it. It'll be nice to have while we wait on the updated version.

Glad to help any way I can.

— Reply to this email directly, view it on GitHub https://github.com/fateh999/react-native-paper-dropdown/pull/71#issuecomment-1170377504, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD5WDBWIC2VFG7QZSLVPOW3VRSMLVANCNFSM52GXYNMA . You are receiving this because you were mentioned.Message ID: @.***>