fatfreecrm / fat_free_crm

Ruby on Rails CRM platform
http://www.fatfreecrm.com
Other
3.56k stars 1.32k forks source link

Internationalize phone numbers #701

Open johnnyshields opened 6 years ago

johnnyshields commented 6 years ago
CloCkWeRX commented 6 years ago

I like the control, but that's going to be a lot of data migration for a lot of people, some who would only do business within their own country. When this lands, we'll want a lot of data migration helpers/rake tasks/etc to make it as painless as possible

steveyken commented 6 years ago

Agree. Could we make it an optional extra that can be turned on? I can see it being very useful for some but not all.

On Fri, Jan 19, 2018, 08:02 CloCkWeRX notifications@github.com wrote:

I like the control, but that's going to be a lot of data migration for a lot of people, some who would only do business within their own country. When this lands, we'll want a lot of data migration helpers/rake tasks/etc to make it as painless as possible

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/fatfreecrm/fat_free_crm/issues/701#issuecomment-358823000, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJGzn76jzXNlu6x0svdb-CsUji9jB_cks5tL9uMgaJpZM4Ri5PY .

johnnyshields commented 6 years ago

@CloCkWeRX @steveyken it's a best practice to store all phone numbers in the DB as E.164 format (we can add a seperate "phone_extension" field as extensions aren't included in E.164)

I'm fine add a "international phone" option in the settings but I think it should be set to true for newly created apps when you run "ffcrm:setup"