search

fatfreecrm / ransack_ui

Framework for building a search UI with Ransack
MIT License
18 stars 20 forks source link

HTML5 input types for value fields #14

Open markedmondson opened 9 years ago

markedmondson commented 9 years ago

We're looking to ditch datepicker since modern browsers implement this on the correctly typed html5 inputs.

I made a few tweaks with this in mind, sadly, the only "reliable" way to do it is to clone the value input, change the type and inject the clone, I'm wondering if anyone could see any reason why this wouldn't work?

https://github.com/Guestfolio/ransack_ui/tree/html5

(this relies on #12 being merged)

steveyken commented 9 years ago

Thanks, I've merged PR #12 now so this work is freer to move forward. I'm in favour of what you've suggested above and can't see a better way to do it right now. Do you want to wrap up a pull request with the relevant work and we'll look to merge it in. Thanks again. Steve