search

fatfreecrm / ransack_ui

Framework for building a search UI with Ransack
MIT License
18 stars 20 forks source link

Override for table name fix for Rails 7.1 #25

Closed stanleylhs closed 1 week ago

stanleylhs commented 1 week ago

Cherrypicked commit from Ransack 4.1.1 for Rails 7.1 as table_name is deprecated. https://github.com/activerecord-hackery/ransack/pull/1439/commits/eac3c37d3d9a22179071dd150f01e7a5bfaefa9c

CloCkWeRX commented 1 week ago

Anything stopping us from just updating to 4.1.1+?

stanleylhs commented 1 week ago

Anything stopping us from just updating to 4.1.1+?

This is the issue @steveyken is having https://github.com/activerecord-hackery/ransack/issues/1403

steveyken commented 1 week ago

I've created https://github.com/fatfreecrm/ransack_ui/issues/26 to handle the upgrade from v3 to v4. In the meantime, this is a suitable monkey patch fix to provide Rails 7.1 compatibility.

stanleylhs commented 1 week ago

Ah, I should have made comments in the code about this being a monkey patch, say removed this after v4 upgrade.