fatg3erman / RompR

Web client for Mopidy and MPD
https://fatg3erman.github.io/RompR/
Other
190 stars 22 forks source link

music from everywhere fails to exclude sources #112

Closed jimydirektsaft closed 3 years ago

jimydirektsaft commented 3 years ago

In personalised radio > music from everywhere > play from these sources select only "local". Create a "Last.FM Lucky Dip" playlist.

RompR selects tracks from the local library and from other sources. In the attached personalised-radio.log you can see that one spotify track was added to the playlist.

jimydirektsaft commented 3 years ago

debug information:

fatg3erman commented 3 years ago

I'm completely unable to reproduce this under any circumstances.

Your log is extremely confusing. Please send one at level 6 that starts when you activate the Last.FM radio station (tail it and pipe to another file, like in the docs).

jimydirektsaft commented 3 years ago

Ok - I found that happens if I've opened one browser with rompr, in which "local" is marked as source and a second browser with rompr, in which "local" and "spotify" are marked as sources. If I select the last.fm radio from the first browser with only "local" selected the playlist gets populated with tracks from local and from spotify. If I close the second browser (where "local" and "spotify" are selected) the playlist gets populated only with tracks from local.

Please find the trace log from the session with two open browsers in the attached file.

logtrace.txt

fatg3erman commented 3 years ago

Essentially that is how it is supposed to work.

Populating the radio stations is decentralised - any open browser can do it. For that to make sense the browser has to honour the sources options selected, and that selection has to be honoured if it is changed during population. I can't change the options in one browser to match the other, because which ones are the "correct" ones? Honestly there's no reliable way to know.

The only correct "fix" for this, I'm afraid, is to make sure you select appropriate options in how ever many browsers you have open.

jimydirektsaft commented 3 years ago

That's reasonable. Thank you for your kind reply. From my user centric point of view I would suggest to sync the souces options between browsers (maybe by a preferences config option) but you already wrote that you can't change the options in one browser to match the other. So I think the current behaviour is a bit irritating but I absolutely can live with it. In any way RompR is a great thing! Thanks again!

fatg3erman commented 3 years ago

I'll leave this open to remind me to think about it, you never know, I might come up with something :)

fatg3erman commented 3 years ago

In version 1.57, just released, I've made a change that I think should fix this. All browsers should now share the same radio source options. You will need to change them one, from any browser, for this to take effect.