Open tljohnsn opened 3 years ago
Need to fix that. I have to grey out repeat, shuffle, and consume but crossfade should remain accessible.
Which version of RompR are you using, and which skin? I just tried this and I can toggle Crossfade when personalised radio is playing.
rompr-1.59.1 with Tablet or Phone skin
I can't reproduce this at all, with any skin. Are you able to send the debug information from the Debug Information plugin, and perhaps a screenshot of it happening?
Screenshot without personalized radio:
Screenshot after enabling personalized radio:
I can't reproduce this behaviour, and looking at the code I can't even see how it's possible. I think it has to be down to your installation - old versions did used to behave like that, I found a commit from a long time ago that changed it.
Can you try the tablet skin in a desktop browser and tell me if it does the same thing?
If you are using rompr on a phone or tablet and you've set it up as an icon on your home screen, can you try in a browser instead? You might even need to clear the browser cache.
If none of that works can you delete everything except albumart and prefs from your rompr installation and copy 1.59.1 back in there.
The screenshot in my previous comment was from the tablet skin in chrome on osx. I just reinstalled 1.59.1 completely on a pi and used safari and got the same thing. I've never used safari on this machine before so I don't think there could be a cache issue.
My install procedure was as follows: VERSION=1.59.1 unzip -q rompr-$VERSION.zip mkdir rompr/{prefs,albumart} mkdir -p rompr/prefs/databackups sudo mv rompr /var/www/html sudo chown -R www-data.www-data /var/www/html/rompr
Then in the prefs I set the music folder to /home/ftp/local I loaded up rompr and the options were still grey:
I have noticed that crossfade does indeed work, it is just grey, so it is not that big of a deal. I thought it might be an easy fix, sorry about that.
Thanks for looking at it further, I agree it looked like it should have been an easy fix :) I have to say I'm mystified, I can't reproduce the behaviour and there's literally nowhere in the code where I grey out that button.
So you're saying you can still toggle crossfade on and off but the button is greyed out?
I'll leave this open but right now I don't think there's anything I can do about it.
I can't toggle it while personalized radio is playing. It just remains in whatever state it was in before starting.
I am using mpd and the cross fade works fine when playing without personalized radio. However once I start a station like "3 or more stars" the cross fade icon becomes gray and can't be used.