Closed adrhc closed 2 years ago
fatg3erman
commented
2 years ago This is not a bug. The file is not 'missing', it simply does not exist. Rompr is checking to see if it exists, the 404 response is used to establish that it doesn't.
Please don't just look at logs and assume something is wrong, unless you understand how the code works.
adrhc
commented
2 years ago The same Rompr "binaries" on the same browser is working differently on Raspberry Pi OS comparing to Ubuntu 21.10 where GET /themes/Numismatist.css.js works. Are you, @fatg3erman, still sure that is not a bug?
fatg3erman
commented
2 years ago It's not a bug, in the sense that that file doesn't exist and is not supposed to exist.
The behaviour difference is odd though. I just had a closer look at the code and in fact, the custom 404 handler I use is designed to prevent you from seeing a 404 error in the console when it tries to get that file. So in facts it is working correctly on Ubuntu.
I also tried it on my raspberry pi setup and I see the same behaviour you see on Ubuntu. This suggests that your 404 handler isn't set up correctly. What do you see if you try to navigate to a page that doesn't exist, on your Raspberry Pi setup? And which webserver are you using?
fatg3erman
commented
2 years ago Can you paste your nginx config file for rompr here?
adrhc
commented
2 years ago server {
listen 80 default_server;
listen [::]:80 default_server;
root /var/www/rompr/;
index index.php index.html index.htm;
server_name raspberrypi;
client_max_body_size 512M;
error_page 404 = /rompr/404.php;
# This section can be copied into an existing default setup
location / {
allow all;
index index.php;
location ~ \.php {
include snippets/fastcgi-php.conf;
fastcgi_pass unix:/var/run/php/php7.4-fpm.sock;
fastcgi_read_timeout 864000;
}
# error_page 404 = /rompr/404.php;
try_files $uri $uri/ =404;
location ~ /albumart/* {
expires -1s;
}
}
}All other resources are accessed without error, only GET /themes/Numismatist.css.js?_=1652994749366 fails, on Raspberry Pi OS only. Rompr also seems to work fine, I'm listening music right now, controlling it with Rompr.
fatg3erman
commented
2 years ago See the other post, your error_page directive is wrong.
Yeah, the error won't affect whether rompr works or not as there's a fallback already defined for the case where the script doesn't exist.
It happens on Raspbian GNU/Linux 11 (bullseye) but not Ubuntu, same browser with cache disabled.
Rompr version: 1.61