search

father-bot / chatgpt_telegram_bot

💬 Telegram bot with ChatGPT, Python-based, using OpenAI's API.
https://t.me/chatgpt_karfly_bot
MIT License
5.18k stars 1.81k forks source link

Add gpt4-vision feature. #395

Open lvmax1998 opened 1 year ago

lvmax1998 commented 12 months ago

Hello, I hope you're doing well! First of all, I want to thank you for your valuable suggestions. They are incredibly helpful! I've decided to implement your suggestions by adding a history conversation feature, allowing users to review previous dialogues. It's going to be so convenient! Additionally, I will modify the scope of the message variable to make it more flexible. This is fantastic!

By the way, I have a question. Why can't I see your comments on this pull request? (Please forgive my newbie mistakes when I first started contributing). Add gpt4-vision feature. by lvmax1998 · Pull Request #395 · karfly/chatgpt_telegram_bot (github.com)?

Well, that's all for now! Looking forward to hearing from you!

Sent from Mail for Windows

From: Igor Udot Sent: 2023年11月22日 16:28 To: karfly/chatgpt_telegram_bot Cc: lvmax1998; Mention Subject: Re: [karfly/chatgpt_telegram_bot] Add gpt4-vision feature. (PR #395)

Hello, @lvmax1998. As I see, there is no history for user messages. It gets cleaned when the "done" function is called here. But what if it is not called or an error occurs? In that case, the content will still be here. https://github.com/lvmax1998/chatgpt_telegram_bot/blob/bd7bcf449161b6449543ba3c8148dd647c6df852/bot/vision_handle.py#L150 Also, on the other hand, what do you think about moving a variable from the global scope? https://github.com/lvmax1998/chatgpt_telegram_bot/blob/bd7bcf449161b6449543ba3c8148dd647c6df852/bot/vision_handle.py#L16C13-L16C13 — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

horw commented 11 months ago

I think it's because I used comments in the code instead of starting a review or something like this.