search

fathominfo / delphy-web

Other
5 stars 0 forks source link

switching sample frequency skips the confirmation dialog and locks up #15

Closed mark-fathom closed 2 weeks ago

mark-fathom commented 3 weeks ago

To recreate, run the demo for a few steps at the default rate of sampling 1x / million. Pause the run, and switch to a different sample rate. You immediately get a loading screen like the below:

Screen Shot 2024-10-30 at 10 52 37 AM

The app is frozen in this state, and checking the console reveals that a worker threw an error (but we don't know what).

You should get a screen asking whether you wish to through away the progress so far. Upon selecting yes, then we should reload the screen. But it shouldn't freeze.

mark-fathom commented 2 weeks ago

@patvarilly I tracked this down to an error happening in Delphy.delphyCoreRaw.parse_fasta_into_initial_tree_async. I'll try to debug what's happening in this step, but might need your help here.

FWIW, working on branch ms-i15-sampsizeswitch-241101

mark-fathom commented 2 weeks ago

Ah, I need to detect whether we are restarting from a maple file or a fasta!