fathomnet / community-feedback

1 stars 0 forks source link

Allow suggested IDs not in the autocomplete to be sent #128

Open ermbutler opened 1 year ago

ermbutler commented 1 year ago

Currently, on Image Details - in the "History/Comment" area when you choose to "Suggest ID and Comment" only selected items from the taxonomy autocomplete are sent to the backend. Typed suggestions do not trigger onChange and the value is then not read.

This screen shot shows the use case where a user is trying to enter the new accepted name for that animal (Swiftia kofoidi -> Callistephanus kofoidi), but it is not sending to the back end. This example is lifted from feedback from @joostdaniels (with help from @kevinsbarnard).

image

ermbutler commented 1 year ago

Notes from looking quickly:

Typing isn’t triggering onChange to this type of component or its specific setup. The onchange sets the concept and if it is set it is sent to the backend. Since this autocomplete is shared we need to consider that we don't want "type anything" everywhere perhaps. So in that case, to avoid issue it might be easier to duplicate and specialize the component for this area.

hohonuuli commented 7 months ago