search

fathomnet / fathomnet-py

FathomNet Python client
https://fathomnet-py.readthedocs.io
MIT License
24 stars 3 forks source link

New flags for fathomnet_generate.py #2

Closed eor314 closed 2 years ago

eor314 commented 2 years ago

Two suggestions for flags for the fathomnet_generate command line tool:

  1. Flag to grab all concepts from objects that satisfy other filters.
  2. Filter by image dimensions. This might make it easier to select among the cameras that have been deployed on MBARI ROVs.
kevinsbarnard commented 2 years ago
  1. Flag to grab all concepts from objects that satisfy other filters.

Could you clarify this? There is the --all flag to include all concepts from images that were found by the specified filters, if that's what you mean. Or, do you mean something along the lines of "don't filter by any concept, just filter by X Y Z metadata"?

  1. Filter by image dimensions.

Could you provide an example usage of what you're envisioning? I would caution against using image dimensions as a proxy for camera identity, as the letterbox removal process has produced a wide variety of resolutions.

eor314 commented 2 years ago
  1. The latter: "don't filter by any concept, just filter by X Y Z metadata"?
  2. Right, I forgot about letter boxing. I was hoping to filter by sensor. There are some overlapping dates for when different cameras were on different ROVs (a la this list that @hohonuuli furnished on Slack). I suppose holding off on this one is right call and we can think about how to do it later.
kevinsbarnard commented 2 years ago
  1. Resolved in c278ba5
  2. I'll hold off on this.