search

fatiando / boule

Reference ellipsoids for geodesy and geophysics
https://www.fatiando.org/boule
BSD 3-Clause "New" or "Revised" License
38 stars 17 forks source link

Add definition of “co-located grids” to the glossary #139

Closed MGomezN closed 1 year ago

MGomezN commented 1 year ago

Addition requested in #138

Relevant issues/PRs:

Fixes #138

leouieda commented 1 year ago

Pulled this commit into #139 since they make more sense as a single change.

leouieda commented 1 year ago

Oops, just noticed that I posted messages to the wrong PRs...

leouieda commented 1 year ago

@MGomezN this PR and #140 are better as a single change (adding to the glossary and then using the glossary term in the docs). So I pulled the commit from that PR into this one. So I'll be closing that one and commenting here instead.

In the future, you can keep pushing to the same branch to update the PR if there are further changes you want to make before the PR is merged. The balance of what goes into a single PR and what should be multiple is tricky and we've been playing it by ear. A good rule of thumb is: does this PR make sense on its own? If not, then maybe further changes can be added there. Otherwise, then it would be better as a follow-up PR.

None of this is too strict and it's always possible to change as we go along (pulling commits into separate PRs is doable with a little git magic 😉). So don't worry too much about getting it right from the start. We rarely do and often have discussions along these lines.