Add geocentric_radius to TriaxialEllipsoid

[blazej-bucha]

Add a new geocentric_radius method to TriaxialEllipsoid that computes the geocentric surface radius of points in triaxial ellipsoids. Add two new flattening properties to the class: the meridional_flattening and the equatorial_flattening. Add tests and references for the equations used.

---

• Add the geocentric_radius method to the TriaxialEllipsoid class that computes the radius of surface points on triaxial ellipsoids.
• Add tests to check geocentric_radius of TriaxialEllipsoid.
• Running make format made few edits also to the previous code.

Please take a look at the PR to check if it makes sense.

Relevant issues/PRs:

Fixes #105

[welcome[bot]]

💖 Thank you for opening your first pull request in this repository! 💖

A few things to keep in mind:

• Authorship Guidelines: Our rules for giving you credit for your contributions, including authorship on publications and Zenodo archives.
• Code of Conduct: How we expect people to interact in our projects.

⭐ No matter what, we are really grateful that you put in the effort to do this! ⭐

[santisoler]

Hi @blazej-bucha! Thanks so much for opening this PR! I'm really sorry for the delay of my reply.

I think this is a great addition. Let me review it a little bit and will come back with comments.

Regarding the code-style Action that fails, apparently you run an older version of Black that used to format every power operator (**) with leading and trailing spaces. The updated version of Black we use in Boule formats simple power operators without spaces between the base and the power (check this section in Black's docs).

[blazej-bucha]

Hi @santisoler,

Thanks for looking at the pull request and for your comments! All your suggestions should now be applied. In addition, reverting the order of input parameters in geocentric_radius necessitated a few more edits in tests that call this method.

Formating should now hopefully be OK. Previously, I used indeed an older version of Black from Debian repos.

[blazej-bucha]

@santisoler, thanks for your edits! I directly commited all of them.

I'm now happy with the pull request, too. Thanks again for reviewing the code.

[santisoler]

Thanks @blazej-bucha for the contribution! I've just made a few style changes and removed some unused variables that flake was complaining about. I'm merging this! 🚀

[welcome[bot]]

🎉 Congrats on merging your first pull request and welcome to the team! 🎉

If you would like to be added as a author on the Zenodo archive of the next release, add your full name, affiliation, and ORCID (optional) to the AUTHORS.md file of this repository. Feel free to do this in a new pull request if needed.

We hope that this was a good experience for you. Let us know if there is any way that the contributing process could be improved.

[leouieda]

@blazej-bucha thanks for this! Please see the message above ☝🏾 about adding yourself to the AUTHORS.md file.