fatiando / boule

Reference ellipsoids for geodesy and geophysics
https://www.fatiando.org/boule
BSD 3-Clause "New" or "Revised" License
37 stars 16 forks source link

Add mass, mean_density, and volume_equivalent_radius properties #173

Closed MarkWieczorek closed 3 months ago

MarkWieczorek commented 3 months ago

This PR addresses the issue https://github.com/fatiando/boule/issues/164 concerning the addition of mass, mean_density, and volume_equivalent_radius properties to the ellipsoid classes. The following changes were made:

Comments

And, I'm happy to modify anything to conform to your coding standards that are higher than mine!

Relevant issues/PRs: Fixes #164

welcome[bot] commented 3 months ago

💖 Thank you for opening your first pull request in this repository! 💖

A few things to keep in mind:

No matter what, we are really grateful that you put in the effort to do this!

leouieda commented 3 months ago

I agree that we don't need to worry about multiplying a few more times. This is not something called in a loop.

welcome[bot] commented 3 months ago

🎉 Congrats on merging your first pull request and welcome to the team! 🎉

If you would like to be added as a author on the Zenodo archive of the next release, add your full name, affiliation, and ORCID (optional) to the AUTHORS.md file of this repository. Feel free to do this in a new pull request if needed.

We hope that this was a good experience for you. Let us know if there is any way that the contributing process could be improved.