Closed MarkWieczorek closed 7 months ago
💖 Thank you for opening your first pull request in this repository! 💖
A few things to keep in mind:
⭐ No matter what, we are really grateful that you put in the effort to do this! ⭐
I agree that we don't need to worry about multiplying a few more times. This is not something called in a loop.
🎉 Congrats on merging your first pull request and welcome to the team! 🎉
If you would like to be added as a author on the Zenodo archive of the next release, add your full name, affiliation, and ORCID (optional) to the AUTHORS.md
file of this repository. Feel free to do this in a new pull request if needed.
We hope that this was a good experience for you. Let us know if there is any way that the contributing process could be improved.
This PR addresses the issue https://github.com/fatiando/boule/issues/164 concerning the addition of
mass
,mean_density
, andvolume_equivalent_radius
properties to the ellipsoid classes. The following changes were made:_constants.py
to house to the gravitational constantG
that is imported into the three ellipsoid classes.mass
,mean_density
, andvolume_equivalent_radius
to each of the three ellipsoid classes.mean radius
: This is, in fact, not the mean radius of the sphere (i.e., the degree 0 coefficient of the shape), but rather is the mean of the semi-axes (a + b + c)/3. This is defined as R_1 in WGS84 Moritz1988.Comments
volume_equivalent_radius
is(self.volume * 3 / 4 / np.pi)**(1 / 3)
. If we expanded the definition ofself.volume
we could probably save a couple multiplications (but at the expense of readability).Sphere
docstrings. For me, these quantities are defined so that all classes take the same parameters.And, I'm happy to modify anything to conform to your coding standards that are higher than mine!
Relevant issues/PRs: Fixes #164