search

fatiando / boule

Reference ellipsoids for geodesy and geophysics
https://www.fatiando.org/boule
BSD 3-Clause "New" or "Revised" License
38 stars 17 forks source link

Turn longitude_semimajor_axis into an optional attribute #183

Closed MarkWieczorek closed 7 months ago

MarkWieczorek commented 7 months ago

This PR turns longitude_semimajor_axis (renamed to semimajor_axis_longitude) into an optional attribute that is used to instantiate triaxial ellipsoids.

Previously, this parameter was found as an optional argument to the geocentric radius function. However, this parameter is an intrinsic property of the ellipsoid, and will be necessary for all routines that make use of longitude coordinates. As this is now declared as a class attribute, I have thus remove this optional parameter from geocentric radius.

The test_geocentric_radius_semimajor_axis_longitude was somewhat modified: I declared a new ellipsoid triaxialellipsoid_90 that set semimajor_axis_longitude to 90.

As soon as this PR is merged, I will add the centrifugal_potential method (which requires the updated geocentric_radius function).

Note that at some point, we may want to allow for ellipsoids that are not rotating about the z axis, but this is probably far off into the future.

Relevant issues/PRs:

MarkWieczorek commented 7 months ago

This PR was incorporated into #180