Closed santisoler closed 4 years ago
@santisoler I made a few changes here: mostly moved the function to a boule/tests/utils.py
module and made some adjustments to the function (calculating sin and cos only once).
We could remove the sphere test from this branch so we can merge it with tests passing. Then we can implement it in #52 so that we're confident that we can fix the sphere gravity. What do you think?
We could remove the sphere test from this branch so we can merge it with tests passing. Then we can implement it in #52 so that we're confident that we can fix the sphere gravity. What do you think?
I agree. I will move the Somigliana test on the sphere to #52.
Thanks for the modifications, they are way better than what I drafted yesterday.
👍🏽 feel free to merge whenever you're ready
Add tests functions to compare ellipsoids' normal gravity on their surface against the Somigliana equation.
Reminders:
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
and the base__init__.py
file for the package.AUTHORS.md
file (if you haven't already) in case you'd like to be listed as an author on the Zenodo archive of the next release.