fatiando / boule

Reference ellipsoids for geodesy and geophysics
https://www.fatiando.org/boule
BSD 3-Clause "New" or "Revised" License
38 stars 17 forks source link

Tests normal gravity against Somigliana equation #51

Closed santisoler closed 4 years ago

santisoler commented 4 years ago

Add tests functions to compare ellipsoids' normal gravity on their surface against the Somigliana equation.

Reminders:

leouieda commented 4 years ago

@santisoler I made a few changes here: mostly moved the function to a boule/tests/utils.py module and made some adjustments to the function (calculating sin and cos only once).

leouieda commented 4 years ago

We could remove the sphere test from this branch so we can merge it with tests passing. Then we can implement it in #52 so that we're confident that we can fix the sphere gravity. What do you think?

santisoler commented 4 years ago

We could remove the sphere test from this branch so we can merge it with tests passing. Then we can implement it in #52 so that we're confident that we can fix the sphere gravity. What do you think?

I agree. I will move the Somigliana test on the sphere to #52.

Thanks for the modifications, they are way better than what I drafted yesterday.

leouieda commented 4 years ago

👍🏽 feel free to merge whenever you're ready