search

fatiando / boule

Reference ellipsoids for geodesy and geophysics
https://www.fatiando.org/boule
BSD 3-Clause "New" or "Revised" License
38 stars 17 forks source link

Replace Travis and Azure for GitHub Actions #57

Closed santisoler closed 3 years ago

santisoler commented 3 years ago

Add GitHub Actions workflows for checking style, testing and deploying Boule, based on the workflows of Harmonica. Remove TravisCI and Azure configuration files. Split make check target in two: make black-check and make flake8. Ditch Travis and Azure badges on README.rst. Add new GitHub Actions badge. Tests are run on every matrix configuration: all OSs and all Python versions. Use pip to install dependencies instead of setting up miniconda.

Related to fatiando/maintenance#1

leouieda commented 3 years ago

Before merging, we need to have the PyPI and Test PyPI tokens in the repository secrets.

I just added those. I also sent you an invitation for the Test PyPI accounts of all our packages.

leouieda commented 3 years ago

@santisoler I tried using the Actions python with pip instead of conda and this cut down the test times from 3-4 minutes to ~1 min. It's really not necessary to use conda for Boule and many of our other packages that don't need complex dependencies. Rockhound might be the exception since now even numba can be pip installed.

This might be a more significant speed up for CI than almost anything else we do.

santisoler commented 3 years ago

Thanks @leouieda for the review and all the changes. I agree with the decision of install everything with pip instead of conda, specially for packages like Boule.

Rockhound might be the exception since now even numba can be pip installed.

I don't know what you meant on this sentence. Did you mean Harmonica?

leouieda commented 3 years ago

I don't know what you meant on this sentence. Did you mean Harmonica?

I mean that RockHound might require netCDF if we want to run any tests. But if not, then it should be fine. I think harmonica would be fine as well.

santisoler commented 3 years ago

I mean that RockHound might require netCDF if we want to run any tests. But if not, then it should be fine. I think harmonica would be fine as well.

Oh, now I get it! Sure, we can try it out on Harmonica and see if it works.

I think this is looking great. Please merge if no more changes should be made.

leouieda commented 3 years ago

Fingers crossed that the deploy works 🤞🏽

santisoler commented 3 years ago

Thanks for merging! Seems that deploys worked as charmed. Though one of the Mac OS tests was cancelled for no reason. Just rerun all jobs.