fatiando / boule

Reference ellipsoids for geodesy and geophysics
https://www.fatiando.org/boule
BSD 3-Clause "New" or "Revised" License
38 stars 17 forks source link

Add a warning if a point is outside the ellipsoid #66

Closed MGomezN closed 3 years ago

MGomezN commented 3 years ago

Add warning for the normal gravity formula when the height is negative Issue #44

Reminders:

welcome[bot] commented 3 years ago

💖 Thanks for opening your first pull request! 💖

Please make sure you read the following:

A few things to keep in mind:

santisoler commented 3 years ago

Congratulations @MGomezN for opening the PR! :tada: :medal_sports: :rocket:

Let me know if you need some code review or any help!

leouieda commented 3 years ago

@MGomezN thanks for the contribution! It's much appreciated!

One thing I noticed is that your commits don't seem to be linked to your GitHub account (your profile picture should appear instead of the gray GitHub icons). This usually happens when you use a different email to configure git on your machine than the one you used with your GitHub account. My recommendation would be to configure git on your machine with:

  1. You full name: `git config --global user.name "Leonardo Uieda"
  2. The email you use for GitHub: `git config --global user.email "leouieda@github.com"

See http://swcarpentry.github.io/git-novice/02-setup/index.html

You don't need to change the existing commits (that will be fixed when we merge this PR) but you might want to do that for future commits.

MGomezN commented 3 years ago

Congratulations @MGomezN for opening the PR! 🎉 🏅 🚀

Let me know if you need some code review or any help!

Thank you! Yes! I couldn't test my modifications, but I think I know what the problem is... I will try to work on Fridays, Saturdays, and Sundays. So, let me try to fix as much as I can and I will come back to you for help. Thank you!

MGomezN commented 3 years ago

@MGomezN thanks for the contribution! It's much appreciated!

One thing I noticed is that your commits don't seem to be linked to your GitHub account (your profile picture should appear instead of the gray GitHub icons). This usually happens when you use a different email to configure git on your machine than the one you used with your GitHub account. My recommendation would be to configure git on your machine with:

  1. Your full name: `git config --global user.name "Leonardo Uieda"
  2. The email you use for GitHub: `git config --global user.email "leouieda@github.com"

See http://swcarpentry.github.io/git-novice/02-setup/index.html

You don't need to change the existing commits (that will be fixed when we merge this PR) but you might want to do that for future commits.

Thank you @leouieda, as I said in the slack channel, I think I will cause too much trouble in the beginning. Thank you for the patience