fatiando / boule

Reference ellipsoids for geodesy and geophysics
https://www.fatiando.org/boule
BSD 3-Clause "New" or "Revised" License
38 stars 17 forks source link

Add option to return normal gravity in SI units #69

Closed dabiged closed 3 years ago

dabiged commented 3 years ago

This PR adds an option to return gamma in SI units for the normal_gravity method in both the ellipsoid and sphere classes as per #46 . I have included an example in the sphere docstring and added tests for both classes.

Reminders:

dabiged commented 3 years ago

First time using pytest :blush: Thanks for the pointers. It is much cleaner now.

leouieda commented 3 years ago

First time using pytest

@dabiged it's pretty sweet, right? I only learned about these tricks several years after picking it up.

All that is left now is pleasing pylint. I left a comment above and that should do the trick.

Also, please feel free to add yourself to AUTHORS.md (if you'd like of course). We use that to give attribution when we publish Zenodo archives of new versions. If you add yourself, we'd be happy to list you as co-author on the archives 🙂 This is entirely optional, of course.

leouieda commented 3 years ago

👍🏽 merged! Loving all the PRs coming in @dabiged 🙂