search

fatiando / ensaio

Practice datasets to probe your code
https://www.fatiando.org/ensaio
BSD 3-Clause "New" or "Revised" License
21 stars 7 forks source link

Use Ensaio in Boule #35

Closed leouieda closed 2 years ago

leouieda commented 2 years ago

Before we commit to v1.0.0 (https://github.com/fatiando/ensaio/issues/2), we should start using it in our other packages.

This issue tracks the progress of implementing this in Boule. Link back to it when opening issues and PRs in the Boule repository. Boule doesn't really any datasets but it would be great to include some gravity disturbance calculations in the docs there, which we currently don't have.

aguspesce commented 2 years ago

Hello @leouieda! I can do this, or you have started working on this issue?

leouieda commented 2 years ago

@aguspesce no I haven't. Any help is greatly appreciated 🙂 I can pay in a cute baby appearance during a future meeting

aguspesce commented 2 years ago

@leouieda, I saw Boule's code and noticed that it doesn't have any datasets to download from Esaio. I'm wrong?

leouieda commented 2 years ago

You're right, there are no data in Boule at the moment (that was me copy-pasting incorrectly...). So for this it would be a matter of adding it as a documentation dependency and including an example loading the Earth gravity data and calculating normal gravity + the disturbance.

And now that I say that, we should really work to get some Mars and Moon gravity grids onto Ensaio 🌔

aguspesce commented 2 years ago

@leouieda, Harmonica has an example where calculate the disturbance (gravity_disturbance).

Do you want to create something similar in Boule?

leouieda commented 2 years ago

@aguspesce I think @santisoler was reworking the examples to focus on the Souther Africa data rather than the global grid for the disturbance. So maybe we can have global disturbance calculation in the Boule docs as a complement? What do you think?

aguspesce commented 2 years ago

So maybe we can have global disturbance calculation in the Boule docs as a complement? What do you think?

I like the idea! I can create an example for Boule to calculate the gravity disturbance

leouieda commented 2 years ago

Alright, this is done and working both in fatiando/boule#102 and fatiando/boule#130