fatiando / harmonica

Forward modeling, inversion, and processing gravity and magnetic data
https://www.fatiando.org/harmonica
BSD 3-Clause "New" or "Revised" License
211 stars 69 forks source link

Specify "spherical latitude" when describing coordinates of point masses #321

Closed Esteban82 closed 2 years ago

Esteban82 commented 2 years ago

Add "spherical" when describing the spherical latitude coordinate of point masses in the user guide. This way we differentiate it from the "latitude" geodetic coordinate.

I just add 'spherical' following the description of the coordinate system where 'latitude' is used for geodetic (NOT spherical) coordinates.

Is this correct? Now I have some doubts.

welcome[bot] commented 2 years ago

💖 Thank you for opening your first pull request in this repository! 💖

A few things to keep in mind:

No matter what, we are really grateful that you put in the effort to do this!

santisoler commented 2 years ago

Thanks @Esteban82 ! You're right that we should put "spherical" in there to distinguish it from the geographical latitude. I'm merging this.

Feel free to add yourself to the AUTHORS.md file, you can do it on a separate PR. More info on the Authorship Guidelines

welcome[bot] commented 2 years ago

🎉 Congrats on merging your first pull request and welcome to the team! 🎉

If you would like to be added as a author on the Zenodo archive of the next release, add your full name, affiliation, and ORCID (optional) to the AUTHORS.md file of this repository. Feel free to do this in a new pull request if needed.

We hope that this was a good experience for you. Let us know if there is any way that the contributing process could be improved.

Esteban82 commented 2 years ago

You're right that we should put "spherical" in there to distinguish it from the geographical latitude. I'm merging this.

Below, in the same file there was another mention of "latitude". I am not sure if it should be "spherical latitude".

santisoler commented 2 years ago

Below, in the same file there was another mention of "latitude". I am not sure if it should be "spherical latitude".

Nice catch. I'm changing it right away.