Closed LL-Geo closed 7 months ago
Pushed into the wrong branch at the beginning 😅..
Should be able to go... I think I will work on the Choclo for the spherical kernel when I find time :)
Rename g_northing to g_n and g_easting to g_e!
Thanks @santisoler for the review 😄 It looks like it is in good shape. There is an error pup up from the test related to pyVista:
FAILED ..\tests\test_visualizations.py::test_prism_to_pyvista[numpy] - AttributeError: 'UnstructuredGrid' object has no attribute 'cell_bounds' FAILED ..\tests\test_visualizations.py::test_prism_to_pyvista[xarray] - AttributeError: 'UnstructuredGrid' object has no attribute 'cell_bounds' ========== 2 failed, 466 passed, 126 skipped, 80 warnings in 57.42s =========== mingw32-make: *** [makefile:32: test_coverage] Error 1 Error: Process completed with exit code 2.
I'll have a look later
Thanks for reporting it @LL-Geo! I have fixed it in #433, feel free to update this branch whenever you want.
Greetings from another continent... I guess this one is ready to merge... :)
Thanks @santisoler :)
I'll merger that, haha
Is this our first PR merged from Antarctica?? 🐧 ❄️
Is this our first PR merged from Antarctica?? 🐧 ❄️
Haha, Yeppp~ 🐧
Relevant issues/PRs: