fatiando / harmonica

Forward modeling, inversion, and processing gravity and magnetic data
https://www.fatiando.org/harmonica
BSD 3-Clause "New" or "Revised" License
208 stars 68 forks source link

Update point source use Choclo #422

Closed LL-Geo closed 7 months ago

LL-Geo commented 1 year ago
  1. Update point source use Choclo
  2. Rename the kernel from kernel_g_z_spherical to kernel_gravity_u_spherical
  3. Update tesseroid associate with kernel name change
  4. Update Test add Choclo

Relevant issues/PRs:

LL-Geo commented 1 year ago

Pushed into the wrong branch at the beginning 😅..

Should be able to go... I think I will work on the Choclo for the spherical kernel when I find time :)

Rename g_northing to g_n and g_easting to g_e!

LL-Geo commented 11 months ago

Thanks @santisoler for the review 😄 It looks like it is in good shape. There is an error pup up from the test related to pyVista:

FAILED ..\tests\test_visualizations.py::test_prism_to_pyvista[numpy] - AttributeError: 'UnstructuredGrid' object has no attribute 'cell_bounds' FAILED ..\tests\test_visualizations.py::test_prism_to_pyvista[xarray] - AttributeError: 'UnstructuredGrid' object has no attribute 'cell_bounds' ========== 2 failed, 466 passed, 126 skipped, 80 warnings in 57.42s =========== mingw32-make: *** [makefile:32: test_coverage] Error 1 Error: Process completed with exit code 2.

I'll have a look later

santisoler commented 11 months ago

Thanks for reporting it @LL-Geo! I have fixed it in #433, feel free to update this branch whenever you want.

LL-Geo commented 8 months ago

Greetings from another continent... I guess this one is ready to merge... :)

LL-Geo commented 7 months ago

Thanks @santisoler :)

I'll merger that, haha

santisoler commented 7 months ago

Is this our first PR merged from Antarctica?? 🐧 ❄️

LL-Geo commented 7 months ago

Is this our first PR merged from Antarctica?? 🐧 ❄️

Haha, Yeppp~ 🐧