search

fatiando / harmonica

Forward modeling, inversion, and processing gravity and magnetic data
https://www.fatiando.org/harmonica
BSD 3-Clause "New" or "Revised" License
208 stars 68 forks source link

Raise error when GRD file is corrupted #451

Open santisoler opened 7 months ago

santisoler commented 7 months ago

Description of the desired feature:

In case the GRD file that is intended to be read is corrupted and there are missing elements in the grid, our hm.load_oasis_montaj_grid function will fail, raising an error complaining about not being able to reshape the grid to the expected shape.

We could improve the user interface by checking if the number of elements in the read 1d array matches the expected shape and raise an error with an informative error message if it doesn't. It could be a ValueError with a message like: 

f"Encountered grid with {n} elements that doesn't match the expected shape ({shape}). The '{filename}' file is possibly corrupted."

The idea for this new feature was triggered after a conversation with @marcoutojr

Are you willing to help implement and maintain this feature?

Yes, sure! Although I'd love to see someone else tackling this issue.

leouieda commented 7 months ago

Good catch! Nice to see @marcoutojr here 🥳