Merge magnetic forward functions for dipoles

fatiando / harmonica

Forward modeling, inversion, and processing gravity and magnetic data

https://www.fatiando.org/harmonica

BSD 3-Clause "New" or "Revised" License

208 stars 68 forks source link

Merge magnetic forward functions for dipoles #453

Closed santisoler closed 4 months ago

santisoler commented 6 months ago

Merge the two forward functions for magnetic fields of dipoles into a single one named dipole_magnetic that includes a new field argument. Make the dipole_magnetic function to ask magnetic moment vectors as a tuple of three arrays, where each one of these arrays. Update tests accordingly. Update the user guide page about forward modelling of prisms.

Relevant issues/PRs:

Fixes #450

Implements the same interface as #448

santisoler commented 5 months ago

@indiauppal I think this is ready to be merged. Would you like to take a look at it and review it? Feel free to say no if you don't feel like it, no pressure!

santisoler commented 4 months ago

Thanks a lot @indiauppal! Just pushed two minor changes I caught, nothing critical. After CI passes I'll merge this. Hope these changes turn out to be helpful.