Remove depth_type from EquivalentSources - Githubissues

fatiando / harmonica

Forward modeling, inversion, and processing gravity and magnetic data

https://www.fatiando.org/harmonica

BSD 3-Clause "New" or "Revised" License

208 stars 68 forks source link

Remove depth_type from EquivalentSources #468

Closed santisoler closed 4 months ago

santisoler commented 5 months ago

Remove the depth_type argument from the EquivalentSources constructor. By default the point sources will be defined using a relative depth strategy. Removed the deprecated relative_depth argument from the constructor. Update the tests for the class and its methods.

Todo:

[x] remove depth_type from gradient boosted equivalent sources and update their tests
[x] remove depth_type from the docs (if any)
[x] check if we need to update the spherical equivalent sources as well

Relevant issues/PRs:

Fixes #423

santisoler commented 4 months ago

Co-authored by @indiauppal as well during a Fatiando Meeting in which we all worked together on this code.