Fix inverted sign in upward derivative filter

fatiando / harmonica

Forward modeling, inversion, and processing gravity and magnetic data

https://www.fatiando.org/harmonica

BSD 3-Clause "New" or "Revised" License

205 stars 66 forks source link

Fix inverted sign in upward derivative filter #479

Closed YagoMCastro closed 3 months ago

YagoMCastro commented 3 months ago

In order to apply the convention of positive upwards, this code:

Inverts signal of expected wavenumber at derivative_upward_kernel function;
Inverts signal of wavenumber at derivative_upward_kernel function;
Invert signal of upward derivative on test_transformations.py

welcome[bot] commented 3 months ago

💖 Thank you for opening your first pull request in this repository! 💖

A few things to keep in mind:

Authorship Guidelines: Our rules for giving you credit for your contributions, including authorship on publications and Zenodo archives.
Code of Conduct: How we expect people to interact in our projects.

⭐ No matter what, we are really grateful that you put in the effort to do this! ⭐

leouieda commented 3 months ago

@YagoMCastro thanks for the fix! Could you please add a description to the PR? Under "relevant issues" you should include Fixes #454 so the issue will be linked here and closed automatically when this is merged.

welcome[bot] commented 3 months ago

🎉 Congrats on merging your first pull request and welcome to the team! 🎉

If you would like to be added as a author on the Zenodo archive of the next release, add your full name, affiliation, and ORCID (optional) to the AUTHORS.md file of this repository. Feel free to do this in a new pull request if needed.

We hope that this was a good experience for you. Let us know if there is any way that the contributing process could be improved.