search

fatiando / harmonica

Forward modeling, inversion, and processing gravity and magnetic data
https://www.fatiando.org/harmonica
BSD 3-Clause "New" or "Revised" License
205 stars 66 forks source link

Fix bug in reduction to the pole requiring dims "easting" and "northing" #509

Open zaarcvon opened 1 month ago

zaarcvon commented 1 month ago

Relevant issues/PRs:

Fixes #439 bug issue: the reduction_to_pole filter produces an error when grid coordinate names are not "northing" and "easting".
Now, it works regardless of grid coordinate names.

leouieda commented 1 month ago

@zaarcvon thank you for the fix! Would you mind adding a quick test in that runs the reduction to the pole with a grid with dims that have another name? It could be a modification of this test https://github.com/fatiando/harmonica/blob/main/harmonica/tests/test_transformations.py#L615 that renames the dims of the test grid before doing RTP. Would be worth checking that the test fails with the code in main first.

zaarcvon commented 1 month ago

Hi, @leouieda! I included a test function. I hope everything is done correctly. This is my first experience working with pytest

zaarcvon commented 3 weeks ago

Hi, @leouieda . I see that some checks are failing. I understand one related to style and will fix it, but it's not clear what the code style/format check is really about.

santisoler commented 2 weeks ago

Hi @zaarcvon. The two check that are failing are due to code style. The format one is easy to solve, we just need to run black on the project. You can do it by running make format in your local repo (https://github.com/fatiando/community/blob/main/CONTRIBUTING.md#code-style). The style one is telling us that flake8 is raising some warnings. You can check them out by clicking in Details, next to the failing check. In this particular case, flake8 is complaining about trailing whitespaces (whitespaces left after the last character of certain lines). When you run make format, black will take care of those as well.