search

fatiando / pooch

A friend to fetch your data files
https://www.fatiando.org/pooch
Other
620 stars 74 forks source link

Use a variable to set the default request timeout #418

Closed leouieda closed 4 months ago

leouieda commented 4 months ago

Using a variable in pooch.downloaders allows users to potentially increase it if they require and allows us to update it easily if required as well. Set it to 30s instead of 5s to allow for slow connections.

Relevant issues/PRs:

Fixes #409

leouieda commented 4 months ago

@paddyroddy had a few minutes to spare so I made this. 30s should be more than enough since it only timeouts if there is no response at all in this time frame. But if it's a variable and you really need it you can set it to a larger value.

Will merge as soon as tests pass and then cut a bugfix release (probably tomorrow or Friday).

paddyroddy commented 4 months ago

Thanks! I had done a similar variable, but was trying to work out a way of not hard coding it