Closed ChetGoerzen closed 2 years ago
💖 Thanks for opening this pull request! 💖
Please make sure you read our Contributing Guide and abide by our Code of Conduct.
A few things to keep in mind:
make format
to make sure your code follows our style guide.Nice job @ChetGoerzen! :+1:
Let us know when you want us to review the code.
I believe that I have completed everything. However, I have been unable to find the expanded form of many of the earth model names. Some models like PREM have the expanded form "Preliminary Reference Earth Model" while some models like IASP91 do not seem to have an expanded form. Even when I read the original paper describing the earth model I am unable to find the expanded form of the name. Will this be alright if some models don't have the expanded form? If this is acceptable should I open another pull request without the WIP
tag?
It looks like some of the checks were unsuccessful. I will resolve these errors before opening another pull request.
Hi @ChetGoerzen sorry for letting this PR hang. I'll have a look as soon as I can at what is hapening with the Python 3.7 build.
Hi @leouieda, thanks for looking into this. I am not familiar with Azure pipelines so I have been unable to troubleshoot the problem myself.
Fixes #30
This pull request adds the ability to download the AK135-f, IASP91, MEAN, PEM-A, PEM-C, PEM-O, MC35, STW105, and TNA/SNA earth models.
The following things have been completed
The following things are still incomplete
make format
andmake check
have not been rundoc/api/index.rst
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.