fatiando / rockhound

NOTICE: This library is no longer being developed. Use Ensaio instead (https://www.fatiando.org/ensaio). -- Download geophysical models/datasets and load them in Python
BSD 3-Clause "New" or "Revised" License
34 stars 15 forks source link

Add Release Drafter to generate the changelog #88

Closed leouieda closed 4 years ago

leouieda commented 4 years ago

This Github Action automatically generates a changelog based on pull requests merged. The .github/workflows/release-drafter.yml sets up the workflow and .github/release-drafter.yml configures the generated changelog. A caveat is that the names of contributors is given only as their Github handle and not the full names (which we were using before). This is a minor sacrifice that I'm willing to make.

Fixes #86

Reminders:

Reminders for Maintainers:

leouieda commented 4 years ago

The template configuration can be set for the whole organization by putting it in the .github repository. We can move this there after we test it out here to avoid having it duplicated across projects.

leouieda commented 4 years ago

Do we really just have to place these files in here? Or is there another step to enable the Action?

santisoler commented 4 years ago

Do we really just have to place these files in here? Or is there another step to enable the Action?

The times I have used GitHub Actions I've done it through the GitHub interface. But I think that it just adds files to .github/workflows and then if they exists, the CI run.

The template configuration can be set for the whole organization by putting it in the .github repository. We can move this there after we test it out here to avoid having it duplicated across projects.

Sure! According to GitHub docs, it should work for every Fatiando repo.

leouieda commented 4 years ago

It seems to be running but I'm getting an error on the configuration file. Not sure why it's complaining though. Maybe because it's running on a branch? Can you spot anything wrong with the configuration rile?

santisoler commented 4 years ago

It seems to be running but I'm getting an error on the configuration file. Not sure why it's complaining though. Maybe because it's running on a branch? Can you spot anything wrong with the configuration rile?

Probably it's looking for a .github/release-draft.yml with the template property on master... BTW, don't know if we should let it run on every branch or only on master. Is the Release Draft modified if we run Release Drafter from a non-master branch?

leouieda commented 4 years ago

I don't know. I just enbled this branch to test the configuration. I think it's safe to remove it and then merge this PR. Then we'll see if things worked or not :man_shrugging:

leouieda commented 4 years ago

:crossed_fingers: alright, let's see if we're lucky!