Fix dropping non-dimensional coordinates in grid_to_table

fatiando / verde

Processing and gridding spatial data, machine-learning style

https://www.fatiando.org/verde

BSD 3-Clause "New" or "Revised" License

604 stars 72 forks source link

Fix dropping non-dimensional coordinates in grid_to_table #441

Closed Souza-junior closed 7 months ago

Souza-junior commented 7 months ago

Add lines to search for extra coordinates and append the information into the list of coordinates and coordinates_name

Fixes #403

Relevant issues/PRs:

welcome[bot] commented 7 months ago

💖 Thank you for opening your first pull request in this repository! 💖

A few things to keep in mind:

Authorship Guidelines: Our rules for giving you credit for your contributions, including authorship on publications and Zenodo archives.
Code of Conduct: How we expect people to interact in our projects.

⭐ No matter what, we are really grateful that you put in the effort to do this! ⭐

Souza-junior commented 7 months ago

Hi @leouieda! I've added the test you asked for.

welcome[bot] commented 7 months ago

🎉 Congrats on merging your first pull request and welcome to the team! 🎉

If you would like to be added as a author on the Zenodo archive of the next release, add your full name, affiliation, and ORCID (optional) to the AUTHORS.md file of this repository. Feel free to do this in a new pull request if needed.

We hope that this was a good experience for you. Let us know if there is any way that the contributing process could be improved.

leouieda commented 7 months ago

Merged! Thanks @Souza-junior 🎉 Please add yourself to the AUTHORS.md file in a new PR.