Suggestion: CI only work for newly added username/domain

[haliliceylan]

Hi,

Now CI checks the previous usernames every time it runs. A previously added user's problematic web page can explode CI.

To fix this, only the newly added username/domain should be checked under PR.

[bsoyka]

I like this. @fatih-yavuz, thoughts?

[fatih-yavuz]

I agree, it is a good idea. We can do that. Also, the existing users with problem can be warned as a following step. Feel free to open a PR

[haliliceylan]

Does anyone have an idea how to do this, as we can only get the changed lines with git commands, but I don't know how to preserve the syntax of the yaml file.

[fatih-yavuz]

I can take a look at it tomorrow evening CET

[haliliceylan]

I did some research about that, maybe;

• we can check directly pull request owner Instead of look file changes

Or

• some magic with git diff ?

Or

• everyone can add new file for domains like halil.yml(links.dev/path) or haliliceylan.yml (gh-username), we can merge and test on ci ? It's actually make sense because at some point the file will get so big that we won't make any changes (a future problem of course)

Just brain storm.

[xYundy]

You can get current production registry.yaml using Git (or just download it https://github.com/fatih-yavuz/links.dev/raw/main/registry.yaml) to temporary directory.

And now you can directly in NodeJS script calculate the diff and check only newly added users.

[fatih-yavuz]

The last approach sounds pretty easy and doable.

[xYundy]

@fatih-yavuz I wrote a simple implementation of that behaviour.

It's behind feature flag (currently directly in script, but I can be also read from cli param or .env file if you wish).