search

fatih / color

Color package for Go (golang)
https://pkg.go.dev/github.com/fatih/color
MIT License
7.3k stars 615 forks source link

Update golang.org/x/sys for Go 1.18 on M1 Macs. #164

Closed tjni closed 2 years ago

tjni commented 2 years ago

This picks up a new 2022 version of golang.org/x/sys which is caused by https://github.com/golang/go/issues/49219 and is needed to fix building using Go 1.18 on aarch64-darwin.

By including this here, when a new version with this change is released, consumers will not need to specify their own indirect dependency on a newer version of golang.org/x/sys.

~In an ideal world, https://github.com/mattn/go-isatty/pull/75 will be accepted and a new version published, so that this can be picked up through it without an indirect dependency, but I am opening a change here too because this project is more active than that one at the moment.~

tjni commented 2 years ago

I spoke too soon, it was accepted! When a new version is released, I will either create a new PR to remove the indirect dependency if this is also merged, or I will update this PR if it hasn't yet.

tjni commented 2 years ago

I updated github.com/mattn/go-isatty to pick this up now.

tjni commented 2 years ago

I just noticed that this was done automatically by dependabot in https://github.com/fatih/color/commit/b3652af9cfa3fc855e7cb740dc6aadbc84960619.