search

fatih / color

Color package for Go (golang)
https://pkg.go.dev/github.com/fatih/color
MIT License
7.15k stars 607 forks source link

Fix multi-parameter println spacing #228

Closed klauspost closed 3 months ago

klauspost commented 3 months ago

fmt.Println will add spaces between elements when there is multiple parameters sent. This is also described in the documentation of this library: Spaces are always added between operands and a newline is appended.

When wrapping the colors parameters were combined using fmt.Sprint(a...) - which does not space out parameters.

Use fmt.Sprintln to combine parameters.

Fixes #218

fatih commented 3 months ago

Thank you @klauspost for the fix. How important is a release for you? I was planning to wait a few weeks before releasing a new version.

klauspost commented 3 months ago

@fatih Not very, as it is cosmetic. I can always pin the master commit. Feel free to keep it for the RGB release.

fatih commented 3 months ago

Got it, thank you again. Feel free to ping me If I forgot the release.

klauspost commented 1 month ago

@fatih Gentle ping.

fatih commented 1 month ago

@klauspost, thanks for the ping. Released a new version https://github.com/fatih/color/releases/tag/v1.17.0