fatih / color

Color package for Go (golang)
https://pkg.go.dev/github.com/fatih/color
MIT License
7.26k stars 615 forks source link

Add Hi* helpers for hi-intensity colors #68

Closed rhysd closed 7 years ago

rhysd commented 7 years ago

Hi,

I added Hi*() helpers (like HiRed()) for hi-intensity colors as well as normal colors.

I added them because only 8 of 16 colors have helpers. I feel hi-intensity colors are as popular as normal colors and used in many places. At least, I wanted to use hi-black for making a text not stand out, and hi-white for making a text be noticeable.

fatih commented 7 years ago

Hi @rhysd This looks ok. I think it would be worth adding because it doesn't break anything. However I would like to see a small addition to the packages documentation that goes over this a little bit. Just check the other examples to get a sense.

rhysd commented 7 years ago

I fixed the point with rebasing.

rhysd commented 7 years ago

However I would like to see a small addition to the packages documentation that goes over this a little bit. Just check the other examples to get a sense.

I tried to revise docs instead of copy-and-paste docs of existing helpers in b4376ec. I'm not sure they are better documents than previous, tho.

fatih commented 7 years ago

@rhysd I meant the examples here: https://github.com/fatih/color/blob/master/doc.go

rhysd commented 7 years ago

@fatih ah, I see... I'll update it today :smile:

rhysd commented 7 years ago

I added Hi* helpers to example code in doc.

fatih commented 7 years ago

Thanks @rhysd, nice update 👍