search

fatih / structtag

Parse and modify Go struct field tags
Other
633 stars 39 forks source link

Export error sentinel values and refactor #25

Closed romshark closed 4 days ago

romshark commented 1 year ago

chore: Upgrade gomod to Go 1.21. perf: Preallocate slice in (*Tags).Keys(). test: Add more tests and improve test coverage. test: Move syntax error testing to TestParseErr. refactor: Use github.com/stretchr/testify to simplify tests. refactor: Use black-box testing (test package with "_test" suffix). refactor: Use generic slice search function to reduce code duplication.

A little more than promised, but I hope you're fine with these changes living in 1 PR (saved me time). Please let me know if you want these changes to be split across multiple PRs.

resolves #24

fatih commented 1 year ago

Hi @romshark

Thank you for the PR. However I'm not interested in any other refactor, nor do I want to change the test package. Our goal is to export the Errors. Could you please open a new PR with only the actual changes we talked about ?

Thank you