Build failed on linux-3.16 due to SET_ETHTOOL_OPS()

[GoogleCodeExporter]

Patch Here (Not sure if compatible with older kernel):
--- sys/dev/netmap/netmap_kern.h.bak    2014-08-18 17:40:02.072733330 +0800
+++ sys/dev/netmap/netmap_kern.h    2014-08-18 17:40:46.040731481 +0800
@@ -789,7 +789,7 @@ nm_set_native_flags(struct netmap_adapte
    na->if_transmit = (void *)ifp->netdev_ops;
    ifp->netdev_ops = &((struct netmap_hw_adapter *)na)->nm_ndo;
    ((struct netmap_hw_adapter *)na)->save_ethtool = ifp->ethtool_ops;
-   SET_ETHTOOL_OPS(ifp, &((struct netmap_hw_adapter*)na)->nm_eto);
+   ifp->ethtool_ops = &((struct netmap_hw_adapter*)na)->nm_eto;
 #endif
 }

@@ -803,7 +803,7 @@ nm_clear_native_flags(struct netmap_adap
    ifp->if_transmit = na->if_transmit;
 #else
    ifp->netdev_ops = (void *)na->if_transmit;
-   SET_ETHTOOL_OPS(ifp, ((struct netmap_hw_adapter*)na)->save_ethtool);
+   ifp->ethtool_ops = ((struct netmap_hw_adapter*)na)->save_ethtool;
 #endif
    na->na_flags &= ~(NAF_NATIVE_ON | NAF_NETMAP_ON);
 #ifdef IFCAP_NETMAP /* or FreeBSD ? */

Original issue reported on code.google.com by lokchu...@gmail.com on 18 Aug 2014 at 9:52

Attachments:

• netmap-3.16.patch

[GoogleCodeExporter]

Hi,

thank you for the patch! However, the issue should be already fixed in the 
'next' branch, commit 0a54e3162b60. Can you please check whether the existing 
fix also works for you?

Original comment by giuseppe.lettieri73 on 19 Aug 2014 at 4:22

[GoogleCodeExporter]

Issue 21 has been merged into this issue.

Original comment by giuseppe.lettieri73 on 28 Sep 2014 at 1:55

[GoogleCodeExporter]

I am closing the issue. Please reopen it if the problem is still there.

Original comment by giuseppe.lettieri73 on 16 Oct 2014 at 12:37

• Changed state: Fixed