search

fatihsolhan / v-onboarding

v-onboarding is a super-slim, fully-typed onboarding component for Vue 3
https://v-onboarding.fatihsolhan.com/
MIT License
170 stars 22 forks source link

Tried changing button titles - nothing happened #51

Closed DominikGanic closed 1 year ago

DominikGanic commented 1 year ago

Hi, I don't know if it's my bad now or not, but I've tried changing the button titles as in the documentation using the labels object.

Here's my code snippet which should change the button title for this step:

image

The button title for the next button with value "Irgendwas" doesn't apply - did I do something wrong?

Another misunderstood case is the overriding of the OnboardingWrapper. Where should I pass the options to change the button titles globally? The documentation is somehow lacking here with samples. :(

Another idea: Could you let us integrate images / assets into the steps? So we could also show some illustrations with the steps. That would be great!

Thanks for your effort again - this plugin has still huge potential as other alternatives are really bad tho and this one works really cool so far. :)

fatihsolhan commented 1 year ago

Hi @DominikGanic the option key should be labels, not label

I'll get back to your other questions in a few hours

DominikGanic commented 1 year ago

Hi @fatihsolhan, great, thanks for your very fast response!

I've researched myself the source code and came up with the global wrapper options solution - and it works great! So in this case, it was my fault and I'm sorry for opening a bug issue way too early. :) Everythin works great.

fatihsolhan commented 1 year ago

Hey @DominikGanic, no worries. I'm glad you resolved the global options question.

You can pass the options prop to the VOnboardingWrapper component. Options are listed on this page

For the images/assets part; I believe it makes more sense to make those customizations with the custom UI. Because if we somehow allow passing an illustration/image to the default UI, the custom UI will be meaningless. I definitely recommend using a custom UI in your case.

Please let me know if this makes sense to you or if you need help with the custom UI