fatmasevinck / enetLTS

Robust and sparse methods for high diemnsional data including gaussian, binomial and multinomial families
https://github.com/fatmasevinck/enetLTS
GNU General Public License v3.0
2 stars 3 forks source link

third last figure in Readme.md #19

Closed fatmasevinck closed 1 year ago

fatmasevinck commented 1 year ago

Dear @marastadler

"You add plots in Readme.md in the multinomial regression section that are not in the manuscript. When plotting the coefficients in the first of these plots, the x-axis label is difficult to read. You could sort the features by importance and/or show only a subset of the coefficients."

Concerning your comment here, you are right. It is difficult to read x-axis label in that figure. But this is because of the number of variables. In multinomial example, we have quite a lot number of variables. That plot is the original plot which is produced directly by function plot.enetLTS(). If someone works with less number of variables, it will be easier to read the x-axis. In this paper, these figures provide some examples for the original plot functions.

marastadler commented 1 year ago

Dear @fatmasevinck, Thanks for the reply to my comment. Okay, but if this particular plot is not appropriate for your data, I recommend removing it from the tutorial.

fatmasevinck commented 1 year ago

@marastadler This plot is suitable for the data. These models are working with high dimensional data. That is why it is important to provide an example for high dimensional data. It is normal to have such an issue in the plot.

fatmasevinck commented 1 year ago

If this part is ok for you, dear @marastadler , I will close this issue.

fabian-s commented 1 year ago

I agree with @marastadler that this: image is a completly terrible plot: it's illegilble, the ordering on the x-axis is completely arbitrary, there's no justfication for using a line plot here since values are not connected, and it's completely unclear what, if any, information readers are supposed to read from it. That said, the README is not the JOSS paper, so this does not seem relevant for the ongoing review process.

fatmasevinck commented 1 year ago

This figure is deleted from README.md file considering the number of variables in this example. Thanks for your comment.