if domain_name set to domain1 the domain is removed

fatmcgav / fatmcgav-glassfish

Rewritten Glassfish module to improve functionality and support.

http://github.com/fatmcgav/fatmcgav-glassfish

GNU General Public License v3.0

6 stars 31 forks source link

Closed nicklaslof closed 9 years ago

nicklaslof commented 9 years ago

If I set domain_name to "domain1" (which is the default name) the module removes the domain every time thinking it's the default domain.

fatmcgav commented 9 years ago

@nicklaslof Ah, that's a nice little bug...

TBH, I didn't expect people would actually use the default value of 'domain1', but guess I can make the removal of 'domain1' optional.

fatmcgav commented 9 years ago

Have just pushed ff4a739ed8a224bbfaa83cd0d04987480270458a to feature/fix-35, which should allow you to retain the default 'domain1' domain.

Let me know if it fixes the issue for you?

dsantanu commented 9 years ago

just a quick question nicklaslo: You testing on Ubuntu or using Redhat? I cannot add "domain" at all on Ubuntu. Best!

fatmcgav commented 9 years ago

I think from #36 nicklaslo is running Ubuntu 12.04...

Am just testing now though :)

dsantanu commented 9 years ago

yes, he is using 14.04 but I'll be surprised if that makes any difference.

fatmcgav commented 9 years ago

Closed in 1f996f5535cad80225654ad3066048e3a5babd12