search

fatmcgav / fatmcgav-glassfish

Rewritten Glassfish module to improve functionality and support.
http://github.com/fatmcgav/fatmcgav-glassfish
GNU General Public License v3.0
6 stars 31 forks source link

Save Master Password and Allow JMS restype ConnectionFactory #37

Closed joliveira closed 9 years ago

joliveira commented 9 years ago

Added switch "--savemasterpassword" to the create-domain command. Using class create-domain after including the base glassfish class causes the create-domain to error stating to include the switch.

jmsresource with restype of javax.jms.ConnectionFactory was not in the list of valid restypes.

Updated the test cases for create-domain and added a test for the ConnectionFactory restype.

fatmcgav commented 9 years ago

@joliveira Looks good to me... Hadn't hit the master password issue before, but looks like there's no harm including it...

Will get this merged in soon...

fatmcgav commented 9 years ago

@joliveira Thanks again for the contribution...

joliveira commented 9 years ago

Great! Thank you!

On Sat, Oct 25, 2014 at 9:36 AM, Gavin Williams notifications@github.com wrote:

@joliveira https://github.com/joliveira Thanks again for the contribution...

— Reply to this email directly or view it on GitHub https://github.com/fatmcgav/fatmcgav-glassfish/pull/37#issuecomment-60488596 .