search

fatmcgav / fatmcgav-glassfish

Rewritten Glassfish module to improve functionality and support.
http://github.com/fatmcgav/fatmcgav-glassfish
GNU General Public License v3.0
6 stars 31 forks source link

need to add a restart domain after enable secure admin #40

Closed scarby closed 9 years ago

scarby commented 9 years ago

it would appear that using this module with secure admin enabled the glassfish domain comes up without secure admin enabled. This is probably not expected behavior - therefore we need to restart the domain before going further

fatmcgav commented 9 years ago

@scarby I do restart the domain already in create_service.pp.

However this change is probably a cleaner way of handling it, so cheers for that :)

scarby commented 9 years ago

ok, i might go back and do some more digging. however i was having an issue making https calls to the glassfish api - despite those calls depending on the glassfish class (within which create_domain is being included) which changing the restart to immediately after the create secure admin fixed. Also given that in theory the module provides an option to create a domain, start it, but not create a service - it might be good for this to come back in the correct state - though this use case is probably not massively useful.

fatmcgav commented 9 years ago

Yeh, i've seen some ordering issues myself which I worked around by ordering against specific resources defined in the glassfish module...

This looks cleaner though. I'll give it a spin and see if can find any issues...

Cheers Gav On 1 Dec 2014 19:24, "scarby" notifications@github.com wrote:

ok, i might go back and do some more digging. however i was having an issue making https calls to the glassfish api - despite those calls depending on the glassfish class (within which create_domain is being included) which changing the restart to immediately after the create secure admin fixed. Also given that in theory the module provides an option to create a domain, start it, but not create a service - it might be good for this to come back in the correct state - though this use case is probably not massively useful.

— Reply to this email directly or view it on GitHub https://github.com/fatmcgav/fatmcgav-glassfish/pull/40#issuecomment-65119550 .