fatmcgav / fatmcgav-glassfish

Rewritten Glassfish module to improve functionality and support.
http://github.com/fatmcgav/fatmcgav-glassfish
GNU General Public License v3.0
6 stars 31 forks source link

Virtual Resource references issue #52

Closed ITler closed 8 years ago

ITler commented 8 years ago

Catalogue compilation will fail due to incompatible Virtual Query definitions with Puppet 4+.

Class['glassfish::path'] -> Create_domain <| |>
Class['glassfish::path'] -> Create_cluster <| |>
Class['glassfish::path'] -> Create_node <| |> 

Should be

Class['glassfish::path'] -> Glassfish::Create_domain <| |>
Class['glassfish::path'] -> Glassfish::Create_cluster <| |>
Class['glassfish::path'] -> Glassfish::Create_node <| |> 

There are multiple files affected. Functional tests pending.

fatmcgav commented 8 years ago

Cheers for flagging these up... I should probably add Puppet 4.x to the TravisCI matrix to see these...

ITler commented 8 years ago

I think, this issue is not specific to Puppet 4.x. Some of your files already have the correct Virtual Queries. Maybe you missed those references while refactoring.

fatmcgav commented 8 years ago

Yeh, I suspect it's been over-looked when re-factoring... However the code works in production with Puppet 3.7, so I'm guessing it's a tightening of the rules in future parser that's done it :)

Cheers

fatmcgav commented 8 years ago

Fixed by #54