fau-fablab / FabLabKasse

FabLabKasse, a Point-of-Sale Software for FabLabs and other public and trust-based workshops
https://fablabkasse.readthedocs.io
GNU General Public License v3.0
15 stars 4 forks source link

Argparse for kassenbuch.py #127

Closed sedrubal closed 8 years ago

sedrubal commented 8 years ago

Sorry, this is much code but it is very, very mighty :)

Remember to run activate-global-python-argcomplete to enable tab completion. (also for deploying on kassenterminal)

mgmax commented 8 years ago

If any argument syntax changed, we also have to update all documentation and cronjobs referring to Kassenbuch.

sedrubal commented 8 years ago

I rebuild the old structure and only changed

./kassenbuch.py client summary <client>

to

./kassenbuch.py client show --detail <client>

because of the redundancy and I made client names equal to their ids...

I didn't find any docu for that...

mgmax commented 8 years ago

I don't understand the comment at "pass # NQA"

sedrubal commented 8 years ago

I wanted to mark this 2 lines as ok, because QuantifiedCode complains them, but I think this is ok. I read #NQA somewhere but I don't know what this means...

mgmax commented 8 years ago

well, if even you don't know what it means then it definitely needs an explaining comment

sedrubal commented 8 years ago

Here you are. But I don't understand, why quantified code don't like this... I thought this is pythonic...

mgmax commented 8 years ago

Well, usually it would be a bad thing to just ignore import errors, so the warning is generally okay. Here we can safely ignore the warning.

sedrubal commented 8 years ago

Ok.

Patrick thinks, one cannot disable single lines for checking...

So is this ready-to-merge?

sedrubal commented 8 years ago

I think, this one can be merged. Any concerns?