WIP: Python3 - Githubissues

fau-fablab / FabLabKasse

FabLabKasse, a Point-of-Sale Software for FabLabs and other public and trust-based workshops

https://fablabkasse.readthedocs.io

GNU General Public License v3.0

15 stars 4 forks source link

WIP: Python3 #145

Closed sedrubal closed 1 year ago

sedrubal commented 7 years ago

Fixes #140

TODO:

[x] Port code using lib2to3 and review changes
[ ] For oerplib replacement we should use odoorpc. But this requires oodo >= 8.
[ ] Fix unittests
[ ] Fix travis
[ ] Adapt and test code for payment devices
[ ] Testing

patkan commented 7 years ago

I can of course review this, but is this change sensible when we currently have no upgrade-path for oerplib? Wouldn't it be better to write code that is both with Python2 and 3 compatible?

sedrubal commented 7 years ago

I don't know.

Both, oerp7 and oerplib are EOL. I think we should change to a maintained version of Odoo soon. Then we can use odoorpc which supports Python3.

Writing compatible code is IMHO much harder as it looks like. I found much code which is very Python2 specific and hard to make compatible. And it won't solve the issue I tried to fix doing this: The complexity about Unicode.

mgmax commented 1 year ago

obsolete --> continued in https://github.com/fau-fablab/FabLabKasse/pull/164