search

fau-fablab / FabLabKasse

FabLabKasse, a Point-of-Sale Software for FabLabs and other public and trust-based workshops
https://fablabkasse.readthedocs.io
GNU General Public License v3.0
15 stars 4 forks source link

draft: migration according to #162 #164

Closed patkan closed 1 year ago

patkan commented 2 years ago

closes #162

mgmax commented 1 year ago

@patkan I need some help / explanation how to run black (which version, which config, etc)

patkan commented 1 year ago

@patkan I need some help / explanation how to run black (which version, which config, etc)

Hi @mgmax could you resolve it? Any black from this year should be good (they have switched to yearly compatibility in the output). Config: no config :-) black does just the right thing :wink: Does that help?

mgmax commented 1 year ago

Hi @mgmax could you resolve it? Any black from this year should be good (they have switched to yearly compatibility in the output). Config: no config :-) black does just the right thing wink Does that help?

Thanks! We should document this somewhere, and ideally provide some "containerized" method (docker-compose, virtualenv, whatever) that doesn't conflict with other black versions on the system.

patkan commented 1 year ago

Hi @mgmax could you resolve it? Any black from this year should be good (they have switched to yearly compatibility in the output). Config: no config :-) black does just the right thing wink Does that help?

Thanks! We should document this somewhere, and ideally provide some "containerized" method (docker-compose, virtualenv, whatever) that doesn't conflict with other black versions on the system.

Agreed. I think somewhen in the past I have tried to set up a VS Code instance that connects into the vagrant machine, but then you have the issue that your code is also in there. Also you are locked into VS Code (and I think you don't use it, do you?)

I will see what I can do.

patkan commented 1 year ago

Hi @mgmax could you resolve it? Any black from this year should be good (they have switched to yearly compatibility in the output). Config: no config :-) black does just the right thing wink Does that help?

Thanks! We should document this somewhere, and ideally provide some "containerized" method (docker-compose, virtualenv, whatever) that doesn't conflict with other black versions on the system.

You can now call ./container_black.sh for a dockerized black. It is configured to exactly the same version as in the github workflow and also configured as the default formatter in vs code.

mgmax commented 1 year ago

I will merge whatever is in here on the weekend (or so). Development can then continue in the main branch (called development for whatever reason).

Any opinions on squash-merge vs regular merge?