IMPROVE platform indepence by removing direct dependency to fcntl

fau-fablab / FabLabKasse

FabLabKasse, a Point-of-Sale Software for FabLabs and other public and trust-based workshops

https://fablabkasse.readthedocs.io

GNU General Public License v3.0

15 stars 4 forks source link

IMPROVE platform indepence by removing direct dependency to fcntl #81

Closed patkan closed 9 years ago

patkan commented 9 years ago

use portalocker instead
portalocker uses on posix-systems fcntl
on nt it does win32api-calls @EmJay276 please test this on windows

patkan commented 9 years ago

The best way would be to use https://github.com/WoLpH/portalocker as submodule or the corresponding pip-package.

patkan commented 9 years ago

I updated the project to use the pip-package. Furthermore I tested the provisioning and it works.

patkan commented 9 years ago

@EmJay276 it would be really nice if you could test it now under Windows. You will probably run into problems later on, but at least file locking should work now ;-)

patkan commented 9 years ago

Ok, we tested it together and the portalocker-lib currently seems to have problems with the win32con-lib. The maintainer @WoLpH seems to be working on it. If no one sees any regressions when using this lib ( @cod3monk Does portalocker work on Mac?), I would propose merging this.

wolph commented 8 years ago

@patkan just a fyi, portalocker has support for the newer windows locking methods now but it seems there is an issue with shared locks: https://github.com/WoLpH/portalocker/issues/29